accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward compatible
Date Fri, 08 Feb 2019 16:44:45 GMT
ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward
compatible
URL: https://github.com/apache/accumulo/pull/943#discussion_r255149552
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
 ##########
 @@ -50,7 +50,7 @@
  * @deprecated since 2.0.0, replaced by {@link Accumulo#newClient()}
  */
 @Deprecated
-public class ClientConfiguration {
+public class ClientConfiguration extends CompositeConfiguration {
 
 Review comment:
   Yes, the type is incompatible with commons-configuration2. However, that problem exists
regardless of whether it is in the public API or not. But, having it in the public API prevents
us from migrating to commons-configuration2. So, it needs to be out of the public API so we
can update it, whether to match what Hadoop is using, for class path convergence, or for security
updates. In all such cases, we cannot upgrade it if it remains in the public API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message