accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward compatible
Date Fri, 08 Feb 2019 07:48:30 GMT
ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward
compatible
URL: https://github.com/apache/accumulo/pull/943#discussion_r254976690
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
 ##########
 @@ -50,7 +50,7 @@
  * @deprecated since 2.0.0, replaced by {@link Accumulo#newClient()}
  */
 @Deprecated
-public class ClientConfiguration {
+public class ClientConfiguration extends CompositeConfiguration {
 
 Review comment:
   Yes, the whole point was to break code that used it in 2.0. This is why we bumped versions
to 1.9 instead of staying on 1.8... for the sole purpose of deprecating out this superclass.
This was documented in the release notes for 1.9.0.
   
   https://accumulo.apache.org/release/accumulo-1.9.0/#deprecated-clientconfiguration-api-using-commons-config
   
   As for marking it deprecated, Java has no way of marking the superclass as deprecated.
So, what we did instead was deprecate all of the methods inherited from the superclass:
   
   https://github.com/apache/accumulo/blob/1.9/core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java#L140
   
   It was only during the 2.0 development that we decided to deprecate the class in its entirety,
in favor of using properties... but that's a separate issue. The methods inherited from the
superclass were declared as deprecated in 1.9... all of them, and we documented this in the
release notes.
   
   We should *not* re-add this API leakage back into the API after already removing it, when
we've already done as much as we have to prepare users, and it fixes a legitimate API leakage.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message