From notifications-return-47148-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Mon Jan 7 20:57:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DB908180661 for ; Mon, 7 Jan 2019 20:57:07 +0100 (CET) Received: (qmail 43609 invoked by uid 500); 7 Jan 2019 19:57:07 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 43597 invoked by uid 99); 7 Jan 2019 19:57:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2019 19:57:06 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] milleruntime commented on a change in pull request #874: Fix MapReduce bug Message-ID: <154689102640.27747.12201004275607360042.gitbox@gitbox.apache.org> Date: Mon, 07 Jan 2019 19:57:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit milleruntime commented on a change in pull request #874: Fix MapReduce bug URL: https://github.com/apache/accumulo/pull/874#discussion_r245778873 ########## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java ########## @@ -88,7 +88,7 @@ public static void setClientInfo(Job job, ClientInfo info) { * * @since 2.0.0 */ - protected static ClientInfo getClientInfo(JobContext context) { + public static ClientInfo getClientInfo(JobContext context) { Review comment: Yeah I will open an issue. There is just a lot of redundant code now in the new map reduce impl that we needed before because of so many methods being in the public API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services