accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #905: fixes #813 close server side session when scanner closed
Date Wed, 16 Jan 2019 22:07:40 GMT
milleruntime commented on a change in pull request #905: fixes #813 close server side session
when scanner closed
URL: https://github.com/apache/accumulo/pull/905#discussion_r248466394
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ScannerIterator.java
 ##########
 @@ -99,6 +106,7 @@ public boolean hasNext() {
     iter = getNextBatch().iterator();
     if (!iter.hasNext()) {
       finished = true;
+      activeIters.remove(this);
 
 Review comment:
   Do you need to synchronize on this remove?  Couldn't one be closed at the same time?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message