accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #880: Make new Bulk Import tableTime take boolean
Date Wed, 09 Jan 2019 16:20:46 GMT
milleruntime commented on a change in pull request #880: Make new Bulk Import tableTime take
boolean
URL: https://github.com/apache/accumulo/pull/880#discussion_r246446664
 
 

 ##########
 File path: proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
 ##########
 @@ -1766,13 +1765,9 @@ public void importDirectory(ByteBuffer login, String tableName, String
importDir
       org.apache.accumulo.proxy.thrift.AccumuloException,
       org.apache.accumulo.proxy.thrift.AccumuloSecurityException, TException {
     try {
-      ImportMappingOptions loader = getConnector(login).tableOperations().importDirectory(importDir)
-          .to(tableName);
-      if (setTime) {
-        loader.tableTime().load();
-      } else {
-        loader.load();
-      }
+      getConnector(login).tableOperations().importDirectory(importDir).to(tableName)
 
 Review comment:
   It had previous only been explicitly enabled and always false otherwise.  This makes logic
internally simpler but the case where the user has a boolean to determine the behavior more
cumbersome.  Now the boolean param is explicit "setValue" with the default staying the same
as false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message