accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #874: Fix MapReduce bug
Date Mon, 07 Jan 2019 19:57:06 GMT
milleruntime commented on a change in pull request #874: Fix MapReduce bug
URL: https://github.com/apache/accumulo/pull/874#discussion_r245778873
 
 

 ##########
 File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java
 ##########
 @@ -88,7 +88,7 @@ public static void setClientInfo(Job job, ClientInfo info) {
    *
    * @since 2.0.0
    */
-  protected static ClientInfo getClientInfo(JobContext context) {
+  public static ClientInfo getClientInfo(JobContext context) {
 
 Review comment:
   Yeah I will open an issue.  There is just a lot of redundant code now in the new map reduce
impl that we needed before because of so many methods being in the public API. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message