accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] joshelser commented on issue #868: Make tserver start repl services when configured
Date Wed, 02 Jan 2019 21:19:05 GMT
joshelser commented on issue #868: Make tserver start repl services when configured
URL: https://github.com/apache/accumulo/pull/868#issuecomment-450988255
 
 
   > I am not too familiar with replication but it's properties might be used in tserver
and master.
   
   That's correct. There's logic across master and tabletserver for replication. The intent
to have its own prefix was to keep all replication configuration in "one place".
   
   > just have a general message in the docs like zk mutable: yes but requires a restart
   
   +1
   
   > With this change, we could throw an illegal state exception if the user sets a property
on the fly, expecting data to get replicated. I am not sure where that would be done though.
   
   That would be client side validation, right? I suppose it's not unreasonable for this case
to let client-side validation be sufficient (e.g. it's not bad if a user circumvents our own
code and tries to set a zk-mutable property -- worst case, it's just ineffectual). That sounds
like a good idea. Even if not an exception, a WARN would go a long way for operators to realize
they straying from the "norm"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message