From notifications-return-46833-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Thu Dec 20 18:05:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 21620180718 for ; Thu, 20 Dec 2018 18:05:06 +0100 (CET) Received: (qmail 81487 invoked by uid 500); 20 Dec 2018 17:05:06 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 81457 invoked by uid 99); 20 Dec 2018 17:05:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2018 17:05:06 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner commented on a change in pull request #842: More cleanup for WAL Message-ID: <154532550569.15058.17753383913998599328.gitbox@gitbox.apache.org> Date: Thu, 20 Dec 2018 17:05:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit keith-turner commented on a change in pull request #842: More cleanup for WAL URL: https://github.com/apache/accumulo/pull/842#discussion_r243345654 ########## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java ########## @@ -398,10 +401,12 @@ public static DFSLoggerInputStreams readHeaderAndReturnStream(FSDataInputStream */ public synchronized void open(String address) throws IOException { String filename = UUID.randomUUID().toString(); - log.debug("Address is {}", address); + if (log.isDebugEnabled()) Review comment: Why add these checks to see if debug is enabled? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services