accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #842: More cleanup for WAL
Date Fri, 28 Dec 2018 15:09:24 GMT
keith-turner commented on a change in pull request #842: More cleanup for WAL
URL: https://github.com/apache/accumulo/pull/842#discussion_r244340795
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -537,22 +538,14 @@ public void close() throws IOException {
       }
   }
 
-  public synchronized void defineTablet(long seq, int tid, KeyExtent tablet) throws IOException
{
+  public LoggerOperation defineTablet(CommitSession cs) throws IOException {
 
 Review comment:
   I like this change to only pass CommitSession 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message