accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #842: More cleanup for WAL
Date Thu, 20 Dec 2018 17:05:05 GMT
keith-turner commented on a change in pull request #842: More cleanup for WAL
URL: https://github.com/apache/accumulo/pull/842#discussion_r243346775
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
 ##########
 @@ -365,7 +366,8 @@ private void write(final Collection<CommitSession> sessions, boolean
mincFinish,
             if (commitSession.beginUpdatingLogsUsed(copy, mincFinish)) {
               try {
                 // Scribble out a tablet definition and then write to the metadata table
-                defineTablet(commitSession, writeRetry);
+                write(singletonList(commitSession), false,
+                    logger -> logger.defineTablet(commitSession), writeRetry);
 
 Review comment:
   Is the `NO_WAIT_LOGGER_OP` behavior preserved?  Not sure if its possible at this depth
in the code, but it would be more clear if define tablet were written using `Durability.LOG`.
 For define tablet we want to write to the log w/o sync because we know define tablet will
be followed by subsequent writes that may or may not sync.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message