accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #842: More cleanup for WAL
Date Thu, 20 Dec 2018 17:05:05 GMT
keith-turner commented on a change in pull request #842: More cleanup for WAL
URL: https://github.com/apache/accumulo/pull/842#discussion_r243345654
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -398,10 +401,12 @@ public static DFSLoggerInputStreams readHeaderAndReturnStream(FSDataInputStream
    */
   public synchronized void open(String address) throws IOException {
     String filename = UUID.randomUUID().toString();
-    log.debug("Address is {}", address);
+    if (log.isDebugEnabled())
 
 Review comment:
   Why add these checks to see if debug is enabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message