accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #829: Stop creating double OuputStreams for WAL
Date Mon, 17 Dec 2018 16:36:15 GMT
keith-turner commented on a change in pull request #829: Stop creating double OuputStreams
for WAL
URL: https://github.com/apache/accumulo/pull/829#discussion_r242221206
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -443,8 +436,12 @@ public synchronized void open(String address) throws IOException {
       byte[] cryptoParams = encrypter.getDecryptionParameters();
       CryptoUtils.writeParams(cryptoParams, logFile);
 
-      encryptingLogFile = new DataOutputStream(
-          encrypter.encryptStream(new NoFlushOutputStream(logFile)));
+      // write directly to logFile if no crypto detected
+      if (encrypter instanceof NoFileEncrypter) {
+        encryptingLogFile = logFile;
+      } else {
+        encryptingLogFile = new NoFlushOutputStream(encrypter.encryptStream(logFile));
 
 Review comment:
   I think `encryptingLogFile` could be of type `DataOutput`.  Based on this we could change
the if to the following.   This will accomplish the same thing with less assumptions. 
   
   ```java
   OutputStream tmp = encrypter.encryptStream(logFile);
   if(tmp instanceof DataOutput) {
     encryptingLogFile = (DataOutput) tmp;
   } else {
     encryptingLogFile = NoFlushOutputStream(encrypter.encryptStream(logFile));
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message