accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #829: Stop creating double OuputStreams for WAL
Date Fri, 14 Dec 2018 23:26:49 GMT
ctubbsii commented on a change in pull request #829: Stop creating double OuputStreams for
WAL
URL: https://github.com/apache/accumulo/pull/829#discussion_r241919099
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -443,8 +436,12 @@ public synchronized void open(String address) throws IOException {
       byte[] cryptoParams = encrypter.getDecryptionParameters();
       CryptoUtils.writeParams(cryptoParams, logFile);
 
-      encryptingLogFile = new DataOutputStream(
-          encrypter.encryptStream(new NoFlushOutputStream(logFile)));
+      // write directly to logFile if no crypto detected
+      if (encrypter instanceof NoFileEncrypter) {
+        encryptingLogFile = logFile;
+      } else {
+        encryptingLogFile = new NoFlushOutputStream(encrypter.encryptStream(logFile));
 
 Review comment:
   I think it would be better to push this conditional down into the encryption abstraction
somehow, rather than do this kind of logic directly in DfsLogger. It'd be nice if DfsLogger
didn't do any crypto logic at all, and simply talked to the next layer output stream.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message