accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #777: Remove hard coded values from BatchWriterConfig
Date Wed, 21 Nov 2018 22:52:47 GMT
milleruntime commented on a change in pull request #777: Remove hard coded values from BatchWriterConfig
URL: https://github.com/apache/accumulo/pull/777#discussion_r235560368
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java
 ##########
 @@ -209,15 +231,15 @@ public void write(DataOutput out) throws IOException {
     // write this out in a human-readable way
     ArrayList<String> fields = new ArrayList<>();
     if (maxMemory != null)
-      addField(fields, "maxMemory", maxMemory);
+      addField(fields, MAX_MEM.getKey(), maxMemory);
 
 Review comment:
   Yeah its not work breaking serialized data.  I will undo the changes to the serialized
code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message