From notifications-return-45778-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri Oct 26 20:09:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9A8D3180675 for ; Fri, 26 Oct 2018 20:09:24 +0200 (CEST) Received: (qmail 18243 invoked by uid 500); 26 Oct 2018 18:09:23 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 18232 invoked by uid 99); 26 Oct 2018 18:09:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 18:09:23 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner opened a new pull request #727: fixes #587 Check deleting state when deciding on tablets Message-ID: <154057736313.3683.16388602954591056392.gitbox@gitbox.apache.org> Date: Fri, 26 Oct 2018 18:09:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit keith-turner opened a new pull request #727: fixes #587 Check deleting state when deciding on tablets URL: https://github.com/apache/accumulo/pull/727 The following two changes were made : * In tableOps.DeleteTable.call() the table state is transitioned to DELETING. This commit ensures the table state cache is updated. These are the changes in TableManager.java. * The main loop in TabletGroupWatcher now checks if tables are DELETED or DELETING. It used to only check for DELETED (which is null). These changes rely on the fact that tableOps.CleanUp.isReady() calls master.hasCycled(). This ensures the current loop that TabletGroupWatcher is running finishes before CleanUp starts deleting metadata entries. With these changes, the next TabletGroupWatcher loop should see the table state changes and not add any junk to the metadata table. Also, slightly unrelated to this bug fix I noticed that the transition table state method in TabletGroupWatcher was not idempotent. Specifically if a FATE delete table op attempted to transition a table to DELETING that was already DELETING it would have thrown an error. Now transitioning DELETING to DELETING should be a noop. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services