accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #718: Made AccumuloClient Closeable
Date Tue, 30 Oct 2018 18:06:10 GMT
keith-turner commented on a change in pull request #718: Made AccumuloClient Closeable
URL: https://github.com/apache/accumulo/pull/718#discussion_r229423637
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/singletons/SingletonReservation.java
 ##########
 @@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.accumulo.core.singletons;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * @see SingletonManager#getClientReservation()
+ */
+public class SingletonReservation implements AutoCloseable {
+
+  // volatile so finalize does not need to synchronize to reliably read
+  protected volatile boolean closed = false;
+
+  private static Logger log = LoggerFactory.getLogger(SingletonReservation.class);
+
+  @Override
+  public synchronized void close() {
+    if (closed) {
+      return;
+    }
+    closed = true;
+    SingletonManager.releaseRerservation();
+  }
+
+  @Override
+  protected void finalize() throws Throwable {
+    try {
+      if (!closed) {
+        log.warn("An Accumulo Client was garbage collected without being closed.");
 
 Review comment:
   I don't think this would cause problems since its once per client.  As for logging, I was
uncertain about adding it.  However I convinced myself it will be useful for peoples initial
transition.  We can always remove this code later w/o causing any change in runtime behavior
of the API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message