accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cjmctague commented on a change in pull request #663: Fixes #421 Organize Fate Operations
Date Tue, 02 Oct 2018 19:55:06 GMT
cjmctague commented on a change in pull request #663: Fixes #421 Organize Fate Operations
URL: https://github.com/apache/accumulo/pull/663#discussion_r222090215
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/create/CreateTable.java
 ##########
 @@ -62,18 +65,19 @@ public long isReady(long tid, Master environment) throws Exception {
 
     // assuming only the master process is creating tables
 
-    Utils.idLock.lock();
+    Utils.getIdLock().lock();
     try {
-      tableInfo.tableId = Utils.getNextId(tableInfo.tableName, master.getContext(), Table.ID::of);
+      tableInfo
+          .setTableId(Utils.getNextId(tableInfo.getTableName(), master.getContext(), Table.ID::of));
 
 Review comment:
   `master` wasn't a context, unfortunately. I just used a local variable to shorten the line
so it won't auto format later down the road.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message