accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #663: Fixes #421 Organize Fate Operations
Date Tue, 02 Oct 2018 18:57:43 GMT
ctubbsii commented on a change in pull request #663: Fixes #421 Organize Fate Operations
URL: https://github.com/apache/accumulo/pull/663#discussion_r222072488
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/create/CreateTable.java
 ##########
 @@ -62,18 +65,19 @@ public long isReady(long tid, Master environment) throws Exception {
 
     // assuming only the master process is creating tables
 
-    Utils.idLock.lock();
+    Utils.getIdLock().lock();
     try {
-      tableInfo.tableId = Utils.getNextId(tableInfo.tableName, master.getContext(), Table.ID::of);
+      tableInfo
+          .setTableId(Utils.getNextId(tableInfo.getTableName(), master.getContext(), Table.ID::of));
 
 Review comment:
   Also, I'd have to double check, but I think master *is* a context, so I'm not sure you
need to pass in `master.getContext()` when you can just pass in `master`. If I'm right, that
could shorten the line enough to make this look prettier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message