accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #669: Use optimized writeV methods in Mutations
Date Tue, 02 Oct 2018 18:26:10 GMT
ctubbsii commented on a change in pull request #669: Use optimized writeV methods in Mutations
URL: https://github.com/apache/accumulo/pull/669#discussion_r222061859
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
 ##########
 @@ -1613,22 +1615,22 @@ public void write(DataOutput out) throws IOException {
     }
     out.write((byte) (0x80 | hasValues));
 
-    WritableUtils.writeVInt(out, row.length);
+    UnsynchronizedBuffer.writeVInt(out, integerBuffer, row.length);
 
 Review comment:
   It's just not obvious that the two different `writeVInt` methods should be expected to
have the sample serialization format in all cases. If they do, this is fine. If not, it's
also fine, we just need a note in the release notes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message