accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #669: Use optimized writeV methods in Mutations
Date Tue, 02 Oct 2018 18:18:15 GMT
milleruntime commented on a change in pull request #669: Use optimized writeV methods in Mutations
URL: https://github.com/apache/accumulo/pull/669#discussion_r222059260
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
 ##########
 @@ -1613,22 +1615,22 @@ public void write(DataOutput out) throws IOException {
     }
     out.write((byte) (0x80 | hasValues));
 
-    WritableUtils.writeVInt(out, row.length);
+    UnsynchronizedBuffer.writeVInt(out, integerBuffer, row.length);
 
 Review comment:
   It should be.  It should be writing the same bytes... i.e. when only 2 bytes from an int
get written, those same 2 bytes should get written.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message