accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #669: Use optimized writeV methods in Mutations
Date Tue, 02 Oct 2018 17:10:42 GMT
milleruntime commented on a change in pull request #669: Use optimized writeV methods in Mutations
URL: https://github.com/apache/accumulo/pull/669#discussion_r222036167
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
 ##########
 @@ -1603,6 +1603,8 @@ private void oldReadFields(byte first, DataInput in) throws IOException
{
 
   }
 
+  private final byte[] integerBuffer = new byte[4];
 
 Review comment:
   Wouldn't this result in a new array be created every time the method is called? Vs just
once, and then reused.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message