accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #663: Fixes #421 Organize Fate Operations
Date Tue, 02 Oct 2018 16:00:46 GMT
milleruntime commented on a change in pull request #663: Fixes #421 Organize Fate Operations
URL: https://github.com/apache/accumulo/pull/663#discussion_r222012322
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/create/CreateTable.java
 ##########
 @@ -62,18 +65,19 @@ public long isReady(long tid, Master environment) throws Exception {
 
     // assuming only the master process is creating tables
 
-    Utils.idLock.lock();
+    Utils.getIdLock().lock();
     try {
-      tableInfo.tableId = Utils.getNextId(tableInfo.tableName, master.getContext(), Table.ID::of);
+      tableInfo
+          .setTableId(Utils.getNextId(tableInfo.getTableName(), master.getContext(), Table.ID::of));
 
 Review comment:
   It's OK the the way it is, I'm not sure messing with the formatter looks much better anyway.
 But to turn the formatter off and then back on requires these lines:
   // @formatter:off
   ...
   // @formatter:on
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message