From notifications-return-44782-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Sep 5 19:55:46 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BF0EA180672 for ; Wed, 5 Sep 2018 19:55:45 +0200 (CEST) Received: (qmail 26996 invoked by uid 500); 5 Sep 2018 17:55:44 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 26980 invoked by uid 99); 5 Sep 2018 17:55:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 17:55:44 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner edited a comment on issue #575: Add splits to table at time of table creation #573 Message-ID: <153617014427.22756.10289110149284274146.gitbox@gitbox.apache.org> Date: Wed, 05 Sep 2018 17:55:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit keith-turner edited a comment on issue #575: Add splits to table at time of table creation #573 URL: https://github.com/apache/accumulo/pull/575#issuecomment-418822594 @jmark99 I am finished reviewing this. These changes look great. The only major outstanding concern I have is making the test use the tables created in these new ways a bit to ensure they are functional. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services