From notifications-return-44759-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Sep 5 01:30:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1E2B180789 for ; Wed, 5 Sep 2018 01:30:16 +0200 (CEST) Received: (qmail 19109 invoked by uid 500); 4 Sep 2018 23:30:15 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 19038 invoked by uid 99); 4 Sep 2018 23:30:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Sep 2018 23:30:15 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] ctubbsii commented on a change in pull request #614: Updated Accumulo dependencies and classpath Message-ID: <153610381529.9010.9286718885239710433.gitbox@gitbox.apache.org> Date: Tue, 04 Sep 2018 23:30:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ctubbsii commented on a change in pull request #614: Updated Accumulo dependencies and classpath URL: https://github.com/apache/accumulo/pull/614#discussion_r215091262 ########## File path: core/src/main/java/org/apache/accumulo/core/summary/Gatherer.java ########## @@ -17,6 +17,7 @@ package org.apache.accumulo.core.summary; +import java.nio.charset.StandardCharsets; Review comment: Although I think static imports should be used sparingly, I do find that static imports of `UTF_8` are more convenient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services