From notifications-return-44753-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Sep 5 00:00:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C54A180789 for ; Wed, 5 Sep 2018 00:00:39 +0200 (CEST) Received: (qmail 94745 invoked by uid 500); 4 Sep 2018 22:00:38 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 94695 invoked by uid 99); 4 Sep 2018 22:00:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Sep 2018 22:00:38 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] ctubbsii commented on a change in pull request #628: Add sec-bugs plugin. Closes #618 Message-ID: <153609843784.25740.14860646477762385629.gitbox@gitbox.apache.org> Date: Tue, 04 Sep 2018 22:00:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ctubbsii commented on a change in pull request #628: Add sec-bugs plugin. Closes #618 URL: https://github.com/apache/accumulo/pull/628#discussion_r215077564 ########## File path: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java ########## @@ -1511,7 +1512,7 @@ public void importTable(String tableName, String importDir) && !entry.getValue().contains(Constants.CORE_PACKAGE_NAME)) { LoggerFactory.getLogger(this.getClass()).info( "Imported table sets '{}' to '{}'. Ensure this class is on Accumulo classpath.", - entry.getKey(), entry.getValue()); + sanitize(entry.getKey()), sanitize(entry.getValue())); Review comment: We've already validated that `entry.getKey()` is a class property, so we probably don't need to sanitize it here. (we don't have class properties which include newlines). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services