accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] alerman commented on a change in pull request #524: Add end row to Volume Chooser environment to enable decisions based on tablet
Date Thu, 27 Sep 2018 18:05:17 GMT
alerman commented on a change in pull request #524: Add end row to Volume Chooser environment
to enable decisions based on tablet
URL: https://github.com/apache/accumulo/pull/524#discussion_r221022513
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2842,17 +2843,19 @@ public AtomicLong getScannedCounter() {
   }
 
   private static String createTabletDirectory(ServerContext context, VolumeManager fs,
-      Table.ID tableId, Text endRow) {
+      Table.ID tableId, KeyExtent extent) {
     String lowDirectory;
 
     UniqueNameAllocator namer = context.getUniqueNameAllocator();
-    VolumeChooserEnvironment chooserEnv = new VolumeChooserEnvironment(tableId, context);
+
+    VolumeChooserEnvironment chooserEnv = new VolumeChooserEnvironment(tableId,
+        new TabletIdImpl(extent), context);
     String volume = fs.choose(chooserEnv, ServerConstants.getBaseUris(context.getConfiguration()))
         + Constants.HDFS_TABLES_DIR + Path.SEPARATOR;
 
     while (true) {
       try {
-        if (endRow == null) {
+        if (extent.getEndRow() == null) {
 
 Review comment:
   Same as above. Now that I am passing the extent down, we need to get the endrow as that
is what we wanted. I can move the getEndRow call up and set it to a local variable if you
would prefer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message