accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on issue #649: TServerUtilsTest fails on master and OSX
Date Fri, 14 Sep 2018 20:54:24 GMT
ctubbsii commented on issue #649: TServerUtilsTest fails on master and OSX
URL: https://github.com/apache/accumulo/pull/649#issuecomment-421481599
 
 
   I recall we had some weird logic in there somewhere that looked for cases where the address
was "0.0.0.0" and then tried to figure out the host for the localhost itself. Passing in the
hostname directly, when we have it makes sense to me; maybe we can avoid that dubious logic.
As to why it might have happened on Mac only, Linux has a "myhostname" name service for /etc/nsswitch.conf
that facilitates reverse lookup of the local hostname. Maybe that might help explain why it
didn't fail on Linux, but I haven't done a deep dive.
   
   The change looks correct to me... passing in the hostname explicitly. If this results in
weird behavior with bind address, I'm sure we'll catch and fix that before release. I'm not
worried.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message