accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #628: Add sec-bugs plugin. Closes #618
Date Wed, 05 Sep 2018 18:22:06 GMT
milleruntime commented on a change in pull request #628: Add sec-bugs plugin. Closes #618
URL: https://github.com/apache/accumulo/pull/628#discussion_r215377024
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
 ##########
 @@ -1511,7 +1512,7 @@ public void importTable(String tableName, String importDir)
             && !entry.getValue().contains(Constants.CORE_PACKAGE_NAME)) {
           LoggerFactory.getLogger(this.getClass()).info(
               "Imported table sets '{}' to '{}'.  Ensure this class is on Accumulo classpath.",
-              entry.getKey(), entry.getValue());
+              sanitize(entry.getKey()), sanitize(entry.getValue()));
 
 Review comment:
   I forgot... so with spotbugs, we either have to skip the whole function or sanitize both
params.  And since the value can contain anything, I'm leaning to keep the sanitize on both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message