accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #575: Add splits to table at time of table creation #573
Date Wed, 05 Sep 2018 17:42:47 GMT
keith-turner commented on a change in pull request #575: Add splits to table at time of table
creation #573
URL: https://github.com/apache/accumulo/pull/575#discussion_r215358986
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/PopulateMetadata.java
 ##########
 @@ -52,4 +95,16 @@ public void undo(long tid, Master environment) throws Exception {
         environment.getMasterLock());
   }
 
+  /**
+   * Create a map containing an association between each split directory and a split value.
+   */
+  private Map<Text,Text> createSplitDirectoryMap(SortedSet<Text> splits, SortedSet<Text>
dirs) {
 
 Review comment:
   Could add `Preconditions.checkArgument(splits.size() == dirs.size());`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message