accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #575: Add splits to table at time of table creation #573
Date Wed, 05 Sep 2018 17:42:47 GMT
keith-turner commented on a change in pull request #575: Add splits to table at time of table
creation #573
URL: https://github.com/apache/accumulo/pull/575#discussion_r215347527
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/ChooseDir.java
 ##########
 @@ -41,16 +50,64 @@ public long isReady(long tid, Master environment) throws Exception {
   public Repo<Master> call(long tid, Master master) throws Exception {
     // Constants.DEFAULT_TABLET_LOCATION has a leading slash prepended to it so we don't
need to add
     // one here
-    VolumeChooserEnvironment chooserEnv = new VolumeChooserEnvironment(tableInfo.tableId,
-        master.getContext());
-    tableInfo.dir = master.getFileSystem().choose(chooserEnv,
-        ServerConstants.getBaseUris(master.getConfiguration())) + Constants.HDFS_TABLES_DIR
-        + Path.SEPARATOR + tableInfo.tableId + Constants.DEFAULT_TABLET_LOCATION;
+    
+    VolumeChooserEnvironment chooserEnv = new VolumeChooserEnvironment(tableInfo.tableId);
+
+    String baseDir = master.getFileSystem().choose(chooserEnv, ServerConstants.getBaseUris())
 
 Review comment:
   Looking at this, I wonder if the volume chooser should be called for each tablet.  Not
sure, need to investigate.   I can look into this.  Could also be a follow on issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message