accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #628: Add sec-bugs plugin. Closes #618
Date Tue, 04 Sep 2018 22:00:37 GMT
ctubbsii commented on a change in pull request #628: Add sec-bugs plugin. Closes #618
URL: https://github.com/apache/accumulo/pull/628#discussion_r215077693
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
 ##########
 @@ -1536,6 +1537,14 @@ public void importTable(String tableName, String importDir)
 
   }
 
+  /**
+   * Prevent potential CRLF injection into logs from read in user data
+   * See https://find-sec-bugs.github.io/bugs.htm#CRLF_INJECTION_LOGS
+   */
+  private String sanitize(String msg) {
+    return msg.replaceAll("[\r\n]","");
 
 Review comment:
   with my comment above, this is only used once, so could inline this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message