accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #575: Add splits to table at time of table creation #573
Date Tue, 31 Jul 2018 15:53:24 GMT
keith-turner commented on a change in pull request #575: Add splits to table at time of table
creation #573
URL: https://github.com/apache/accumulo/pull/575#discussion_r206584728
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java
 ##########
 @@ -664,4 +670,41 @@ private String validateNamespaceArgument(ByteBuffer namespaceArg, TableOperation
           TableOperationExceptionType.INVALID_NAME, why);
     }
   }
+
+  /**
+   * Create a file on the file system to hold the splits to be created at table creation.
+   */
+  private String createSplitFile(final long opid, final List<ByteBuffer> arguments,
 
 Review comment:
   > You are correct that there could be an issue if the server went down before the file
was written
   
   Not sure there is a problem with the server going down.   The file is created before the
FATE op is seeded.  If the servers goes down while its trying to setup the FATE op, then the
client will retry RPC to seed fate op and in the process resend the splits.  Need to ensure
the code that creates the split file is idempotent.  If the code is not idempotent, that could
cause problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message