accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jmark99 commented on a change in pull request #575: Add splits to table at time of table creation #573
Date Tue, 31 Jul 2018 14:18:34 GMT
jmark99 commented on a change in pull request #575: Add splits to table at time of table creation
#573
URL: https://github.com/apache/accumulo/pull/575#discussion_r206546601
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java
 ##########
 @@ -664,4 +670,41 @@ private String validateNamespaceArgument(ByteBuffer namespaceArg, TableOperation
           TableOperationExceptionType.INVALID_NAME, why);
     }
   }
+
+  /**
+   * Create a file on the file system to hold the splits to be created at table creation.
+   */
+  private String createSplitFile(final long opid, final List<ByteBuffer> arguments,
 
 Review comment:
   I went with the writing of splits to a temp file on the filesystem  after some discussions
with @keith-turner. Given the size of some of the split sets it wouldn't be feasible to pass
around the data within the FATE operations. Keith suggested writing them to a temporary file
then then reading them in during the FATE operation itself. You are correct that there could
be an issue if the server went down before the file was written, I think we decided that the
odds of that happening would be low (hopefully).  I don't have a better solution at the moment.
I'm open to alternative suggestions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message