accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #549: ACCUMULO-4074 Added support for multiple scan executors
Date Fri, 06 Jul 2018 22:36:40 GMT
keith-turner commented on a change in pull request #549:  ACCUMULO-4074 Added support for multiple
scan executors
URL: https://github.com/apache/accumulo/pull/549#discussion_r200785770
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/session/MultiScanSession.java
 ##########
 @@ -53,17 +48,24 @@ public MultiScanSession(TCredentials credentials, KeyExtent threadPoolExtent,
       Map<KeyExtent,List<Range>> queries, List<IterInfo> ssiList,
       Map<String,Map<String,String>> ssio, Authorizations authorizations,
       SamplerConfiguration samplerConfig, long batchTimeOut, String context) {
-    super(credentials);
+    super(credentials, new HashSet<>(), ssiList, ssio, authorizations);
     this.queries = queries;
-    this.ssiList = ssiList;
-    this.ssio = ssio;
-    this.auths = authorizations;
     this.threadPoolExtent = threadPoolExtent;
     this.samplerConfig = samplerConfig;
     this.batchTimeOut = batchTimeOut;
     this.context = context;
   }
 
+  @Override
+  public Type getScanType() {
+    return Type.MULTI;
+  }
+
+  @Override
+  public String getTableId() {
+    return threadPoolExtent.getTableId().canonicalID();
 
 Review comment:
   That is an SPI method, so I wanted to only use SPI and API types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message