accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #532: More work to remove usage of Instance
Date Tue, 26 Jun 2018 16:01:01 GMT
ctubbsii commented on a change in pull request #532: More work to remove usage of Instance
URL: https://github.com/apache/accumulo/pull/532#discussion_r198203693
 
 

 ##########
 File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
 ##########
 @@ -133,8 +144,8 @@ public static void setConnectorInfo(JobConf job, String principal, Authenticatio
     if (token instanceof KerberosToken) {
       log.info("Received KerberosToken, attempting to fetch DelegationToken");
       try {
-        Instance instance = getInstance(job);
-        Connector conn = instance.getConnector(principal, token);
+        Connector conn = Connector.builder().usingClientInfo(getClientInfo(job))
+            .usingToken(principal, token).build();
 
 Review comment:
   I don't think this behavior is needed. There's no reason to expect the keytab *won't* be
on the worker nodes. If the user wants to use a delegation token, they can create one and
pass it in. This auto-allocation of delegation tokens without user explicit acknowledgement
is probably a bit dangerous anyway and may not be what users intend.
   
   If `getClientInfo` was added solely to support this feature, it is probably not needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message