accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #540: fixes #537 only remove WALs if older WALs can be removed
Date Fri, 22 Jun 2018 19:39:07 GMT
ctubbsii commented on a change in pull request #540: fixes #537 only remove WALs if older WALs
can be removed
URL: https://github.com/apache/accumulo/pull/540#discussion_r197549085
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##########
 @@ -3343,28 +3346,87 @@ public SecurityOperation getSecurityOperation() {
     }
   }
 
-  // remove any meta entries after a rolled log is no longer referenced
-  Set<DfsLogger> closedLogs = new HashSet<>();
+  // This is a set of WALs that are closed but may still be referenced byt tablets. A LinkedHashSet
+  // is used because its very import to know the order in which WALs were closed when deciding
if a
+  // WAL is eligible for removal.
+  LinkedHashSet<DfsLogger> closedLogs = new LinkedHashSet<>();
 
 Review comment:
   Might want to emphasize that this insertion ordering assumes we only have one log open
(and thus one closed) at a time. This isn't future proof if we add multiple open logs, but
as long as we declare that assumption, I think it's fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message