accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] ctubbsii commented on a change in pull request #540: fixes #537 only remove WALs if older WALs can be removed
Date Fri, 22 Jun 2018 19:39:07 GMT
ctubbsii commented on a change in pull request #540: fixes #537 only remove WALs if older WALs
can be removed

 File path: server/tserver/src/test/java/org/apache/accumulo/tserver/
 @@ -0,0 +1,115 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.tserver;
+import java.util.Collections;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Set;
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
+import org.apache.accumulo.core.conf.DefaultConfiguration;
+import org.apache.accumulo.server.fs.VolumeManager;
+import org.apache.accumulo.tserver.TabletServer.ReferencedRemover;
+import org.apache.accumulo.tserver.log.DfsLogger;
+import org.apache.accumulo.tserver.log.DfsLogger.ServerResources;
+import org.junit.Assert;
+import org.junit.Test;
+public class TabletServerTest {
+  static DfsLogger logger(String log) {
 Review comment:
   Method should be private. Also, it could use a small, brief javadoc, something like "make
DfsLogger with mock ServerResources"; alternatively, name the method something like `createMockLogger`.
   "log" param could be "fileName" instead.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message