accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #524: Add end row to Volume Chooser environment to enable decisions based on tablet
Date Thu, 21 Jun 2018 23:18:36 GMT
ctubbsii commented on a change in pull request #524: Add end row to Volume Chooser environment
to enable decisions based on tablet
URL: https://github.com/apache/accumulo/pull/524#discussion_r197302948
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java
 ##########
 @@ -33,15 +35,29 @@
 
   private final ChooserScope scope;
   private final Table.ID tableId;
+  private final Text endRow;
 
   public VolumeChooserEnvironment(ChooserScope scope) {
     this.scope = Objects.requireNonNull(scope);
     this.tableId = null;
+    endRow = null;
   }
 
   public VolumeChooserEnvironment(Table.ID tableId) {
     this.scope = ChooserScope.TABLE;
     this.tableId = Objects.requireNonNull(tableId);
+    endRow = null;
+  }
+
+  public VolumeChooserEnvironment(Table.ID tableId, TabletId tabletId) {
+    this.scope = ChooserScope.TABLE;
+    this.tableId = Objects.requireNonNull(tableId);
+    this.endRow = tabletId.getEndRow();
 
 Review comment:
   Could probably just store the tabletId and provide a getter for that, rather than a getter
for the end row.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message