accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mikewalch commented on a change in pull request #528: Refactored ClientContext & reduced use of Instance
Date Wed, 13 Jun 2018 14:04:50 GMT
mikewalch commented on a change in pull request #528: Refactored ClientContext & reduced
use of Instance
URL: https://github.com/apache/accumulo/pull/528#discussion_r195094637
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/impl/ClientContext.java
 ##########
 @@ -50,11 +49,11 @@
  */
 public class ClientContext {
 
-  protected final Instance inst;
+  private ClientInfo info;
+  protected Instance inst;
 
 Review comment:
   There is already a getter.  It was protected because it is used by `AccumuloServerContext`
which uses it with `instanceof` so not sure if this is necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message