accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #513: Modifications to implement #512
Date Mon, 04 Jun 2018 19:00:12 GMT
ctubbsii commented on a change in pull request #513: Modifications to implement #512
URL: https://github.com/apache/accumulo/pull/513#discussion_r192846919
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java
 ##########
 @@ -50,14 +51,16 @@
   private SamplerConfiguration samplerConfig;
   private boolean enableSampleForDeepCopy;
 
-  public TabletIteratorEnvironment(IteratorScope scope, AccumuloConfiguration config) {
+  public TabletIteratorEnvironment(IteratorScope scope, AccumuloConfiguration config,
+      boolean userCompaction) {
 
 Review comment:
   Boolean parameters are notoriously buggy. It'd be better to use an enum instead of a boolean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message