accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #493: Make RFileScanner use table props throughout
Date Tue, 22 May 2018 16:17:04 GMT
keith-turner commented on a change in pull request #493: Make RFileScanner use table props
throughout
URL: https://github.com/apache/accumulo/pull/493#discussion_r189964644
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
 ##########
 @@ -179,13 +180,14 @@ public void indexWeightChanged() {}
     }
 
     this.opts = opts;
+    ConfigurationCopy tableConf = new ConfigurationCopy(DefaultConfiguration.getInstance());
 
 Review comment:
   It would be nice to void creating the config copy if opt.tableConfig is null. Maybe the
following would do this :
   
   ```java
   AccumuloConfiguration tableConf;
   if(null != opts.tableConfig) {
     tableConf = new ConfigurationCopy(DefaultConfiguration.getInstance());
     opts.tableConfig.forEach(tableConf::set);
   } else {
     tableConf = DefaultConfiguration.getInstance();
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message