accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
Date Sun, 06 May 2018 04:22:07 GMT
ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes
#438
URL: https://github.com/apache/accumulo/pull/456#discussion_r186277966
 
 

 ##########
 File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java
 ##########
 @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class<?>
implementi
    * @param conf
    *          the Hadoop configuration object to configure
    * @param compressionType
-   *          one of "none", "gz", "lzo", or "snappy"
+   *          one of "none", "gz", "lzo", "snappy", or "zst"
 
 Review comment:
   `zstd` instead of just `zst` seems like a better name, since that's the name of the shared
library on disk, the name of the package, and the name of the GitHub repo for the project.
`zst` looks like a letter was forgotten. Is this naming convention necessary for compatibility
with Hadoop, or can we add the `d`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message