accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #444: fixes #432 Made GC clean up recovery logs
Date Thu, 26 Apr 2018 18:11:51 GMT
keith-turner commented on a change in pull request #444: fixes #432 Made GC clean up recovery
logs
URL: https://github.com/apache/accumulo/pull/444#discussion_r184483581
 
 

 ##########
 File path: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
 ##########
 @@ -244,36 +251,53 @@ private long removeTabletServerMarkers(Map<UUID,TServerInstance>
uidMap,
     return result;
   }
 
+  private long removeFile(Path path) {
+    try {
+      if (!useTrash || !fs.moveToTrash(path)) {
+        fs.deleteRecursively(path);
+      }
+      return 1;
 
 Review comment:
   yes, because a dir with mulitple files represents one WAL

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message