accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #444: fixes #432 Made GC clean up recovery logs
Date Thu, 26 Apr 2018 17:57:35 GMT
ctubbsii commented on a change in pull request #444: fixes #432 Made GC clean up recovery logs
URL: https://github.com/apache/accumulo/pull/444#discussion_r184476915
 
 

 ##########
 File path: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
 ##########
 @@ -301,9 +324,8 @@ private UUID path2uuid(Path path) {
           // There's a reference to a log file, so skip that server's logs
           Set<UUID> idsToIgnore = candidates.remove(dead);
           if (idsToIgnore != null) {
-            for (UUID id : idsToIgnore) {
-              result.remove(id);
-            }
+            result.keySet().removeAll(idsToIgnore);
+            recoveryLogs.keySet().removeAll(idsToIgnore);
 
 Review comment:
   Will removing from the keyset remove it from the underlying map?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message