accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #430: #408 - Removed uses of deprecated ClientConfiguration
Date Thu, 19 Apr 2018 21:11:08 GMT
ctubbsii commented on a change in pull request #430:  #408 - Removed uses of deprecated ClientConfiguration
URL: https://github.com/apache/accumulo/pull/430#discussion_r182883297
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
 ##########
 @@ -117,7 +112,7 @@ public ZooKeeperInstance(String instanceName, String zooKeepers, int
sessionTime
    */
   @Deprecated
   public ZooKeeperInstance(UUID instanceId, String zooKeepers) {
-    this(ClientConfiguration.loadDefault().withInstance(instanceId).withZkHosts(zooKeepers));
+    this(null, instanceId.toString(), zooKeepers, -1, new ZooCacheFactory());
 
 Review comment:
   Some of these methods are deprecated. If we are at the point of altering their implementation,
we should probably just remove them, rather than maintain them. In 2.0, we can drop anything
that was deprecated in 1.9.0 or previous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message