accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-3854) [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
Date Mon, 19 Mar 2018 18:03:00 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christopher Tubbs updated ACCUMULO-3854:
----------------------------------------
    Component/s: trace

> [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
> ---------------------------------------------------------------------
>
>                 Key: ACCUMULO-3854
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3854
>             Project: Accumulo
>          Issue Type: Bug
>          Components: trace
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0
>            Reporter: Josh Elser
>            Priority: Minor
>              Labels: findbugs
>             Fix For: 1.7.4, 1.9.0, 2.0.0
>
>
> Noticed this one playing around with ACCUMULO-3853
> If the type of {{sendQueue}} is switched to the concrete ConcurrentLinkedQueue instead
of AbstractQueue, findbugs will catch this as an error because we synchronize on a concurrent
data structure.
> {code}
> -  protected final AbstractQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> +  protected final ConcurrentLinkedQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> {code}
> Should trigger some findbugs warnings from the Maven build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message