From notifications-return-42279-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org  Wed Feb 21 06:20:37 2018
Return-Path: <notifications-return-42279-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id DDA4C180654
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 21 Feb 2018 06:20:36 +0100 (CET)
Received: (qmail 12559 invoked by uid 500); 21 Feb 2018 05:20:35 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 12548 invoked by uid 99); 21 Feb 2018 05:20:35 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 05:20:35 +0000
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] keith-turner commented on a change in pull request #389: ACCUMULO-4805 Optimize file manager when no files to open
Message-ID: <151919043513.18439.10912247457919645429.gitbox@gitbox.apache.org>

keith-turner commented on a change in pull request #389: ACCUMULO-4805 Optimize file manager when no files to open
URL: https://github.com/apache/accumulo/pull/389#discussion_r169537331
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java
 ##########
 @@ -245,20 +245,21 @@ private void closeReaders(Collection<FileSKVIterator> filesToClose) {
   }
 
   private List<String> takeOpenFiles(Collection<String> files, Map<FileSKVIterator,String> readersReserved) {
-    List<String> filesToOpen = new LinkedList<>(files);
-    for (Iterator<String> iterator = filesToOpen.iterator(); iterator.hasNext();) {
-      String file = iterator.next();
-
+    List<String> filesToOpen = Collections.emptyList();
+    for (String file : files) {
       List<OpenReader> ofl = openFiles.get(file);
       if (ofl != null && ofl.size() > 0) {
         OpenReader openReader = ofl.remove(ofl.size() - 1);
         readersReserved.put(openReader.reader, file);
         if (ofl.size() == 0) {
           openFiles.remove(file);
         }
-        iterator.remove();
+      } else {
+        if(filesToOpen.size() == 0) {
 
 Review comment:
   yeah

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services