From notifications-return-42159-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Feb 14 20:00:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E9F1A180621 for ; Wed, 14 Feb 2018 20:00:31 +0100 (CET) Received: (qmail 70322 invoked by uid 500); 14 Feb 2018 19:00:31 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 70310 invoked by uid 99); 14 Feb 2018 19:00:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 19:00:30 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] mikewalch commented on a change in pull request #382: ACCUMULO-4782 switch session manager to a concurrent map Message-ID: <151863483041.32393.11835526414125453735.gitbox@gitbox.apache.org> mikewalch commented on a change in pull request #382: ACCUMULO-4782 switch session manager to a concurrent map URL: https://github.com/apache/accumulo/pull/382#discussion_r168276211 ########## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java ########## @@ -70,20 +84,20 @@ public void run() { }; SimpleTimer.getInstance(conf).schedule(r, 0, Math.max(maxIdle / 2, 1000)); + } - public synchronized long createSession(Session session, boolean reserve) { + public long createSession(Session session, boolean reserve) { Review comment: Might be nice to have an initial state for Sessions and check that it is in that state here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services