From notifications-return-41860-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Jan 31 22:33:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5636518066D for ; Wed, 31 Jan 2018 22:33:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 442F8160C2C; Wed, 31 Jan 2018 21:33:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8898B160C42 for ; Wed, 31 Jan 2018 22:33:48 +0100 (CET) Received: (qmail 70043 invoked by uid 500); 31 Jan 2018 21:33:47 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 69905 invoked by uid 99); 31 Jan 2018 21:33:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 21:33:47 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] milleruntime commented on a change in pull request #361: ACCUMULO-4784 - Create builder for Connector Message-ID: <151743442710.9552.6181133177564061544.gitbox@gitbox.apache.org> milleruntime commented on a change in pull request #361: ACCUMULO-4784 - Create builder for Connector URL: https://github.com/apache/accumulo/pull/361#discussion_r165191356 ########## File path: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java ########## @@ -115,6 +117,21 @@ public static String getClassLoaderContext(JobConf job) { return InputConfigurator.getClassLoaderContext(CLASS, job); } + /** + * Sets connection information needed to communicate with Accumulo for this job + * + * @param job + * Hadoop job instance to be configured + * @param connectionInfo + * Connection information for Accumulo + * @since 2.0.0 + */ + public static void setConnectionInfo(JobConf job, ConnectionInfo connectionInfo) throws AccumuloSecurityException { + ConnectionInfoImpl info = (ConnectionInfoImpl) connectionInfo; Review comment: Another spot where the type should be the interface not the impl. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services