From notifications-return-41848-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Wed Jan 31 16:42:56 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 508CA18067A for ; Wed, 31 Jan 2018 16:42:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3D5F5160C25; Wed, 31 Jan 2018 15:42:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7DCD4160C55 for ; Wed, 31 Jan 2018 16:42:55 +0100 (CET) Received: (qmail 51329 invoked by uid 500); 31 Jan 2018 15:42:54 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 51259 invoked by uid 99); 31 Jan 2018 15:42:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 15:42:54 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner commented on a change in pull request #368: ACCUMULO-4777: fix log messages Message-ID: <151741337390.25191.14659063912810946924.gitbox@gitbox.apache.org> keith-turner commented on a change in pull request #368: ACCUMULO-4777: fix log messages URL: https://github.com/apache/accumulo/pull/368#discussion_r165092154 ########## File path: fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryFactory.java ########## @@ -21,9 +21,11 @@ */ public class RetryFactory { public static final long DEFAULT_MAX_RETRIES = 10l, DEFAULT_START_WAIT = 250l, DEFAULT_WAIT_INCREMENT = 250l, DEFAULT_MAX_WAIT = 5000l; - public static final RetryFactory DEFAULT_INSTANCE = new RetryFactory(DEFAULT_MAX_RETRIES, DEFAULT_START_WAIT, DEFAULT_WAIT_INCREMENT, DEFAULT_MAX_WAIT); + public static final long DEFAULT_LOG_INTERVAL = 10 * 60 * 1000; Review comment: This default seems a bit long to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services